On Sun, 16 Feb 2025 03:25:50 GMT, Rajat Mahajan <[email protected]> wrote:
>> **Issue:**
>> The JNI method `Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon `calls
>> `CreateIconFromRaster `that can throw a C++ exception.
>>
>> The C++ exception must be caught and must not be allowed to escape the JNI
>> method. The call to `CreateIconFromRaster `has to wrapped into a try-catch
>> block.
>>
>> **Solution:**
>>
>> Added exception handling to make sure any exception from
>> `CreateIconFromRaster `is handled properly.
>>
>> Testing done.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> CATCH_BAD_ALLOC
src/java.desktop/windows/native/libawt/windows/awt_Taskbar.cpp line 134:
> 132: ::DestroyIcon(icon);
> 133: }
> 134: catch (const std::bad_alloc&) {
Please follow java style for catch block too.
Suggestion:
} catch (const std::bad_alloc&) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23470#discussion_r1957725917
