On Wed, 19 Feb 2025 23:04:39 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Redo for JComboBox infinite scrolling issue. The issue is that when a >> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) >> while scrolling, when focused is returned to the scrolling application, the >> JComboBox will still be scrolling even though nothing it being clicked. >> >> Previously, a KeyboardFocusListener was added to determine the focus. >> However, there was a memory leak on Windows and Ubuntu. This current >> implementation uses the current FocusManager and is overall a cleaner, >> simpler approach. >> >> CI testing is green on all platforms. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Add test helper Marked as reviewed by azvegint (Reviewer). test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 43: > 41: * @key headful > 42: * @bug 6672644 > 43: * @requires os.family != "mac" Is there a reason to exclude it on mac? Based on my local testing, the issue doesn't affect mac (test passes before and after the fix), but we can still run the test. ------------- PR Review: https://git.openjdk.org/jdk/pull/23451#pullrequestreview-2634609767 PR Review Comment: https://git.openjdk.org/jdk/pull/23451#discussion_r1966393077
