On Wed, 12 Feb 2025 14:36:36 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Where it is checking for subclasses? It is just checking for if the current >> lookandfeel is Windows L&F (as I told it is not checking for `instanceof >> WindowsLookAndFeel` in which case one could have argued that it is trying to >> know about windows subclass.. >> >> Also, having helper method will have effect in only Windows subclass and >> noop in others and that is unnecessary in my opinion and on top of that, it >> will need a CSR for that method and that method would be additional >> maintenance headache and it will prevent backporting this fix if one wants >> to and considering this is related to JCK issue, people would like it to be >> backported.. > > Windows Look-and-Feel is based on Basic L&F implementation — from this point > of view, Basic L&F changes its layout to accommodate for customisations that > are needed for another L&F that's descends from it. Windows L&F change moved to windows class/folder ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1968722160
