On Wed, 26 Mar 2025 19:59:15 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>>> Redarding properties, I think the implementation is OK. The only question >>> in this case is should `getMethodDescriptors()` contain the static method >>> (`public static int DefaultMethodBeanPropertyTest$A4.getStaticValue()`) or >>> not? >> >> It looks like for classes it was implemented as follows: >> - getPropertyDescriptors() checks only instance methods getXXX()/setXXX() >> - getMethodDescriptors() returns all methods of the class, including static >> ones, but static methods are not considered properties >> >> It would be good to cover this by the test > > Also, in the code above, it is not necessary to filter out private methods > since iface.getMethods() returns only public The last question I have is about the module system when the interface is not exported. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r2014917885
