On Fri, 21 Mar 2025 07:41:13 GMT, Roman Marchenko <rmarche...@openjdk.org> 
wrote:

>> src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java 
>> line 81:
>> 
>>> 79:         if (!isInitedToIsGetter && this.readList != null) {
>>> 80:             for (MethodInfo info : this.readList) {
>>> 81:                 if ((this.read == null) || (!info.method.isDefault() && 
>>> this.read.type.isAssignableFrom(info.type))) {
>> 
>> Suggestion:
>> 
>>                 if ((this.read == null) || (!info.method.isDefault()
>>                                             && 
>> this.read.type.isAssignableFrom(info.type))) {
>> 
>> To avoid a rather long line; wrapping at `||` is also an option.
>
> This file already contains lines which are the same length or much longer. 
> But OK, if you like.

Yes, that's true, yet I'd rather not add more long lines, especially longer 
than 100 columns.

According to [The Client Libraries 
Group](https://openjdk.org/groups/client-libs/) and its **Source Code** 
section, “All lines <= 80 chars.” (There are no anchors on the page, so I can't 
link directly to the section.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r2007653564

Reply via email to