On Fri, 4 Apr 2025 20:43:45 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Open-sourced the following Swing tests:
>>
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - JOptionPane changes
> - review changes
test/jdk/javax/swing/JFileChooser/bug4464774.java line 60:
> 58: .instructions(INSTRUCTIONS)
> 59: .rows(10)
> 60: .columns(65)
Why do we need column width of 65 for the above instructions?
test/jdk/javax/swing/JFileChooser/bug4464774.java line 67:
> 65:
> 66: public static JPanel createAndShowUI() {
> 67: JButton button = new JButton("Show JFileChooser");
I guess we can minimize button clicks, instead of showing JFileChooser on
button we can directly show JFileChooser on a Frame right ? I hope there are no
dependency on JButton click and this test?
(same for other applicable test)
test/jdk/javax/swing/JFileChooser/bug4522756.java line 58:
> 56: .title("Instructions")
> 57: .instructions(INSTRUCTIONS)
> 58: .rows(12)
I hope `row` setting is not required?
test/jdk/javax/swing/JOptionPane/bug4194862.java line 25:
> 23:
> 24: /* @test
> 25: @bug 4194862
Suggestion:
* @bug 4194862
test/jdk/javax/swing/JOptionPane/bug4194862.java line 26:
> 24: /* @test
> 25: @bug 4194862
> 26: @summary Tests that internal frame-based dialogs are centered relative
Missing `*`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2032804236
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2032810039
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2032813244
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2032822898
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2032822346
