On Fri, 18 Apr 2025 18:01:08 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove redudant frame
>
> test/jdk/javax/swing/JFileChooser/bug4522756.java line 29:
> 
>> 27:  * @requires (os.family == "windows")
>> 28:  * @summary To verify that if for the first time JFileChooser is opened,
>> 29:             the icon for Desktop is not missing.
> 
> Suggestion:
> 
>  * @summary Verifies that the Desktop icon is not missing when
>             JFileChooser is opened for the first time.
> 
> 
> I presume it refers to the location bar on the left, does it?

The original bug was on GTK+linux only. I have extended it to 
SystemLookAndFeel. Since there are slight variations on how the file filter 
works on different LaF and the test instructions would be confusing if we were 
to account for all variations of installed LaF. Hence limited it System LaF. 
For example on macOS (Aqua LaF) when the txt filter is applied non-text files 
are greyed out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2052763845

Reply via email to