On Tue, 22 Apr 2025 17:58:18 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/RTLScrollers.java >> line 26: >> >>> 24: // A few Swing components which use the mouse wheel to scroll >>> 25: // >>> 26: // NOTE: The robot portion of this test probably has a number of EDT >>> problems, >> >> Yikes. You know that there are EDT problems but just decided to ignore them. >> Are there a lot of them? How hard it would be to get rid of them? > > That's a remnant from the original test. I tried cleaning up the robot calls > and test methods further. Re-tested `HorizScrollers` on my windows machine > and all still looks good. I don't see how it's feasible to call all the > methods in EDT in this JDialog helper class. So far the test looks ok and I > have not encountered any issues, but let me know if you have any suggestions > or concerns. I made what UI elements I could static and volatile to add methods that change UI elements to the EDT. Test still runs as expected and passes on W11. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24758#discussion_r2054654999
