On Tue, 22 Apr 2025 22:11:20 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

> Fixed the failing test by adjusting the EDT block for `runTest`. Also fixed 
> the strange phrasing for one of the instructions. Tested on W11 and passes.

test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java 
line 166:

> 164:                         ("Test %s. Please make sure you have set " +
> 165:                                 "the correct speed value and keep the " +
> 166:                                 "mouse stationary.")

The updated instructions should be corrected as well.

It seems that this `JOptionPane` dialog is only displayed when one of the 
phases fails at non-default speed, and there is no further testing.
So the the `keep the mouse stationary` part is a little bit too late. 

This can be an issue though, but I think it is better to add a delay just 
before the test starts(`RTLScrollers.runTest`) to avoid catching mouse 
movements from a test used when he clicks the button.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24804#discussion_r2055003086

Reply via email to