On Wed, 30 Apr 2025 17:06:39 GMT, Khalid Boulanouare <d...@openjdk.org> wrote:
>> Fixes issue in which the test fails when run on multi-screen machine.
>>
>> Tested on Ubuntu 24.04, MacOS 15 and Windows 11
>>
>> JTREG
>>
>> runner starting test: java/awt/Frame/MultiScreenTest.java
>> runner finished test: java/awt/Frame/MultiScreenTest.java
>> Passed. Execution successful
>
> Khalid Boulanouare has updated the pull request with a new target base due to
> a merge or a rebase. The pull request now contains one commit:
>
> 8352149: test/jdk/java/awt/Frame/MultiScreenTest.java fails in MacOS
It may seem out of scope of this bug but you can add `@Override` annotation for
all overridden methods, not mandatory though.
Please update PR title.
test/jdk/java/awt/Frame/MultiScreenTest.java line 104:
> 102: for (int i = 0; i < gc.length && i < 10; i++) {
> 103: JFrame f = new JFrame(gc[i]); //test JFrame( gc )
> 104: GCCanvas c = new GCCanvas(gc[i]);//test canvas( gc )
For consistency, add a space before start of comment.
Suggestion:
GCCanvas c = new GCCanvas(gc[i]); // test canvas( gc )
-------------
PR Review: https://git.openjdk.org/jdk/pull/24752#pullrequestreview-2828017540
PR Comment: https://git.openjdk.org/jdk/pull/24752#issuecomment-2866264022
PR Review Comment: https://git.openjdk.org/jdk/pull/24752#discussion_r2081510982
