On Wed, 7 May 2025 22:46:08 GMT, Phil Race <p...@openjdk.org> wrote: >> Daniel Gredler has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'master' into ignored-whitespace >> - Make Graphics2D.drawString ignore tabs and newlines on macOS >> - Add actual bug ID >> - Add ignored whitespace test > > I don't think > NativeGlyphMapper - used only when we needs the Xserver to render, or > WPathGraphics - a windows printing class > > are where I'd expect to find anything that could impact the TestControls test. > > But I agree with the general points > - \t \r \n handling can be platform-specific > - macOS printing is very different > > The other PR still needs a proper look on my part > > I suggest we get this PR pushed but first I'll submit a test job .. unless > Harshitha already did that ?
@prrace @honkar-jdk I've incorporated a few minor formatting changes requested by Alexey. Please let me know if you have any concerns with these latest tweaks, otherwise I will go ahead and mark as ready for integration tomorrow. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23665#issuecomment-2872167214
