On Wed, 14 May 2025 07:40:07 GMT, Daniel Gredler <dgred...@openjdk.org> wrote:
> > Looks OK. Testing passes. My only concern would have been if these are > > mutable, but they aren't Unless something casts to a known sub-class that > > is mutable, but I don't know think that is the case. > > It doesn't look like it, but let me know if you'd like me to make > `ExtendedTextSourceLabel` final and make all the instance variables private, > just to tighten things up. I don't think we need to do that. If it is done, a separate clean up PR would be better rather than adding it in here. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25193#issuecomment-2880960222
