On Tue, 20 May 2025 19:18:06 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 43:
>>
>>> 41: import javax.swing.UIManager;
>>> 42:
>>> 43: class MenuItemTestHelper {
>>
>> I would've kept `MenuItemTest` as the name of the class. It's fine either
>> way.
>>
>> I'd also mark this class as `final`. It may be `public` or be left with the
>> default access.
>
> However, `-Helper` could be better — the name of the class clearly indicates
> that this class is not _a test_ but a helper class.
Added final modifier
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2100806967
