On Thu, 22 May 2025 21:21:30 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> The issue was found here: > https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502 > > AWTEventListener and AWTEventListenerProxy are public classes and there's no > assertion that EventListenerProxy.getListener() will always return a non-null > value. So removeAWTEventListener method should fetch the listener from the > proxy and check it for null similar to how it is implemented in > addAWTEventListener. Currently, it works fine because we never insert null > values into the map. So it is just a code clarification. > > One of the test is updated just to touch that codepath. test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java line 41: > 39: EventQueue.invokeAndWait(() -> { > 40: Toolkit tk = Toolkit.getDefaultToolkit(); > 41: I do not know why it was disabled on XToolkit, seems to work fine. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25401#discussion_r2106117597
