On Sat, 24 May 2025 03:32:50 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Set orientation only if changed...add headful in test
>
> src/java.desktop/share/classes/javax/swing/JSplitPane.java line 373:
>
>> 371: public void setComponentOrientation(ComponentOrientation
>> orientation) {
>> 372: if (!orientation.equals(this.getComponentOrientation())) {
>> 373: super.setComponentOrientation(orientation);
>
> I would like to bring up for discussion whether we should move this line
> outside the if block. From what I can tell, it was always executed before the
> initial fix, so this change might affect the original behavior.
If we call setComponentOrientation in test (like in
TestSplitPaneOrientationTest.java which was added for JDK-4265389) then this
check would fail as ComponentOrientation object would change if we call
super.setComponentOrientation outside the if block and so left/right component
would not be set..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25294#discussion_r2106421423
