On Fri, 30 May 2025 00:45:36 GMT, Daniel Gredler <dgred...@openjdk.org> wrote:
>> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2485:
>>
>>> 2483: for (int i = 0; i < len; i++) {
>>> 2484: char c = in_chars[i];
>>> 2485: if (c > '\r' || c < '\t' || c == '\u000b' || c ==
>>> '\u000c') {
>>
>> hmm. looks like you are fixing a bug here. I think those == were supposed to
>> be !=
>
> Hah, I've had to check it a few times but I do think the code was correct --
> just formulated in a confusing way, probably as a micro-optimization.
Although I do think we will end up wanting to add Vertical Tab and Form Feed to
the list of ignored whitespace chars later, as part of JDK-8356803.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24412#discussion_r2114958892
