On Mon, 2 Jun 2025 15:05:44 GMT, Phil Race <p...@openjdk.org> wrote: >> test/jdk/java/awt/FontMetrics/ExtremeFontSizeTest.java line 39: >> >>> 37: /* >>> 38: * @test >>> 39: * @bug 8328896 8357672 >> >> I thought Freetype rasterizer is used on all platforms(Linux, Windows & >> macOS) by default. Since Freetype is part of JDK. >> >> When i run this test on macOS without any updates from this PR on baseline >> code, i see that all Fontmetrics in System.out() are non-zero and match >> before and after extreme parameters. Is this behaviour okay? >> >> I was expecting mismatch in FontMetrics on macOS also. >> If this test is supposed to catch issues on particular platforms. Do we need >> to make it specific to some platforms? > > On mac, freetype is only used in a few cases - Type1 fonts and Font.loadFont. > The test is not Linux-specific, nor should it be constrained to Linux, the > behaviour it validates applies to all platforms. > And if you look at the PR that introduced this test, it did update macOS and > the test did identify issues on macOS. > > So in short, no changes needed.
Thanks for the clarifications. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25511#discussion_r2121477508
