On Fri, 30 May 2025 23:40:22 GMT, Daniel Gredler <dgred...@openjdk.org> wrote:
> Per discussion in JBS, adds the following chars to the list of ignorable > whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next > Line), U+2028 (Line Separator), U+2029 (Paragraph Separator). > > Adds the necessary testing in pre-existing automated test class > `test/jdk/java/awt/font/TextLayout/FormatCharAdvanceTest.java`. > > Removes now-unnecessary manual test > `test/jdk/java/awt/font/TextLayout/TestControls.java`. > > The `test/jdk/java/awt/font`, `test/jdk/java/awt/print` and > `test/jdk/java/awt/Graphics2D/DrawString` tests all pass for me locally on > Windows, Linux and macOS. Tested the fix. It looks good to me. Not sure of the reason behind @aivanov-jdk suggestion in [JDK-8356812](https://bugs.openjdk.org/browse/JDK-8356812) to keep the manual test alongside the automated test. I'm okay with deleting the manual test since the automated one covers all the cases. ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25560#pullrequestreview-2890009923