On Fri, 6 Jun 2025 03:29:47 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> ImageIcon.getNextID uses `mediaTrackerID ` which do not detect overflow. > > Theoretically there is a possibility that there can be overflow in the long > time run or for large number of created "imageIcon" > > Made sure there is no overflow and treat that loadImage as ABORTED > > No regression testcase as it addresses theoretical possibility.. src/java.desktop/share/classes/javax/swing/ImageIcon.java line 305: > 303: return; > 304: } > 305: mTracker.addImage(image, id); Hmm. Is there any acceptable logging we could use here? (I'm just thinking: from the perspective of a developer trying to debug a customer complaint, this would be a lot easier to identify in System.err mentioned it...? Otherwise I'd start by trying to look for potential memory leaks or other red herrings.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25666#discussion_r2131791117
