On Tue, 10 Jun 2025 00:36:24 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> This change is to restore the original intent of the test by updating the 
>> instructions to check that the type of Cursor is preserved when clicked and 
>> dragged. Now the test correctly has instructions to check that an I-beam 
>> cursor stays an I-beam until released over a List with its cursor being 
>> updated to a Hand cursor.
>> 
>> There is a bug where this does not correctly update in macOS (found in 
>> [JDK-7177297](https://bugs.openjdk.org/browse/JDK-7177297)). So, this test 
>> needs to be problem-listed.
>> 
>> I have confirmed that preserving the cursor image when dragging is native 
>> behavior across macOS, Windows, and Ubuntu. And I have checked that the test 
>> passes on both Windows and Ubuntu, while macOS fails and immediately updates 
>> the cursor as it leaves the TextArea.
>
> test/jdk/ProblemList.txt line 837:
> 
>> 835: java/awt/Menu/MenuVisibilityTest.java 8161110 macosx-all
>> 836: java/awt/Modal/NativeDialogToFrontBackTest.java 7188049 
>> windows-all,linux-all
>> 837: java/awt/Cursor/CursorDragTest/ListDragCursor.java 8359061 macosx-all
> 
> Do you mean to use [7177297](https://bugs.openjdk.org/browse/JDK-7177297) in 
> problemlist entry?

Doesn't seem right either. There's a warning about this from the Skara bot.

> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 52:
> 
>> 50:                 pass the test. This test fails if the cursor updates
>> 51:                 when pointing over the different components before
>> 52:                 dragging is complete.
> 
> The new instructions doesn't seem to hold true when I tested on windows.
> Additionally the instructions require rephrasing for clarity?

Perhaps, the instructions need to be adjusted for each OS, or the test should 
be limited to a specific OS only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2137896092
PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2137889078

Reply via email to