On Wed, 11 Jun 2025 17:45:30 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> synchronized for type(char) > > test/jdk/lib/client/ExtendedRobot.java line 237: > >> 235: public void glide(Point src, Point dest) { >> 236: glide(src.x, src.y, dest.x, dest.y, DEFAULT_STEP_LENGTH, >> DEFAULT_SPEED); >> 237: } > > @alisenchung > > Shouldn't `glide(Point src, Point dest)` and `glide(Point dest)` be retained > in ExtendedRobot > In [previous > comment](https://github.com/openjdk/jdk/pull/22044/files#r2085671341) it was > mentioned that these methods won't be migrated so do they need to be retained > in ExtendedRobot ? > > I see `MultipleMouseButtonsTest.java` using `glide(Point src, Point dest)`. > There are two options here: > > 1) Either update the test to use Robot's glide() > change the line `robot.glide(origin, center)` to `robot.glide(origin.x, > origin.y, center.x, center.y);` and completely remove ExtendedRobot versions > of glide. > > 2) Or retain these two convenience methods in ExtendedRobot. There are couple of other tests that use ExtendedRobot version of glide() so probably option 2 (retaining the two convenience methods in ExtendedRobot) might be a better option. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2140796563