On Wed, 11 Jun 2025 19:38:01 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359053
>
> test/hotspot/jtreg/vmTestbase/jit/misctests/fpustack/GraphApplet.java line 33:
>
>> 31: * @library /vmTestbase
>> 32: * /test/lib
>> 33: * @run main/othervm jit.misctests.fpustack.GraphApplet
>
> Why do we delete this test? it is better to update it.
I discussed this test at length with the VM team and it was their request to
delete it as they do not want to invest in updating it.
It has been on the "to be deleted" list (removal_candidates.txt) for at least
7 and likely more than 10 years and it is never run and never will be. At least
not by Oracle.
> test/jdk/javax/sound/sampled/Clip/AudioContentHandlers.java line 51:
>
>> 49: * @run main/othervm -Xmx128m AudioContentHandlers
>> 50: */
>> 51: public final class AudioContentHandlers {
>
> I see the src/java.desktop/share/classes/sun/awt/www/content/audio/ are not
> updated, so what will be the replacement of AudioClip? I guess we should
> return SoundClip now?
I looked into this when I was doing SoundClip.
What is actually returned by contract is a ContentHandler which returns an
Object from its getContent() method
That Object happens to be a com.sun.media.sound.JavaSoundAudioClip which
previously implemented AudioClip
This implements relationship isn't there for SoundClip, so the expectation of
the test that it knows of an exported type that will actually be returned is no
longer valid.
I don't think it is worth testing that JavaSoundAudioClip is returned.
Possibly we could jsut verify that a non-null handler is returned ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2143693619
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2143762913
