On Mon, 16 Jun 2025 14:59:13 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of 
>> ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates 
>> `MediaTracker` to associate the null image to that `id` and checks the 
>> status of loading this null image, removes the null image from the tracker 
>> and then tries to get the image width where it throws NPE as image is null.
>> 
>> It's better to not go through all MediaTracker usage and bail out initially 
>> itself for null image..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix for constructor

src/java.desktop/share/classes/javax/swing/ImageIcon.java line 373:

> 371:     /**
> 372:      * Sets the image displayed by this icon.
> 373:      * Setting null image will not render any image icon.

Suggestion:

     * Setting a {@code null} image will not render any image icon.


Will it sound clearer if the text stated, _“Setting a `{@code null}` image will 
remove the icon?”_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2150283021

Reply via email to