On Tue, 17 Jun 2025 09:09:42 GMT, Srinivas Mandalika <smandal...@openjdk.org>
wrote:
>> Use PassFailJFrame to streamline the test
>> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>>
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added SkippedException when Printer is unavailable.
test/jdk/java/awt/print/Dialog/DialogType.java line 52:
> 50: Two dialogs are shown in succession.
> 51: The test passes as long as no exceptions are thrown, *AND*
> 52: if running on Windows only, the first dialog is a native windows
Windows specific can be as note or even you can append it to instructions on
Windows OS check condition.
test/jdk/java/awt/print/Dialog/DialogType.java line 62:
> 60: }
> 61: PassFailJFrame passFailJFrame = PassFailJFrame.builder()
> 62: .title("DialogType Test Instructions")
Not required.
test/jdk/java/awt/print/Dialog/DialogType.java line 64:
> 62: .title("DialogType Test Instructions")
> 63: .instructions(INSTRUCTIONS)
> 64: .rows((int)INSTRUCTIONS.lines().count() + 2)
Not required.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2153708020
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2153703117
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2153703273
