On Tue, 17 Jun 2025 20:43:24 GMT, Phil Race <p...@openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8359053
>
> I think I have responded to all substantial issues, and in most cases updated 
> the PR according to the feedback.
> Specification questions  that have been raised are resolved and the CSR is 
> approved.
> Unless someone identifies a new problem, I am not expecting to make any 
> changes that would be significant to the CSR or JEP. 
> 
> So I will wait a few days to give people a chance to have a last look but I 
> believe we are getting very close to PTT (Propose To Target) for this JEP - 
> with the target being JDK 26.

@prrace, @mrserb I see the tests aren't new, they're updated.

I viewed only the changes since the last time I'd reviewed the changes and all 
these tests were displayed as new.

Ignoring all the comments to the tests, this leaves only a comment for 
`src/java.desktop/share/classes/java/awt/doc-files/Modality.html`:


-       and now with single application per-VM there is no
-       distinction between application- and toolkit-modality
+       and now with single application per VM there is no
+       distinction between application- and toolkit-modality.


The fix can be applied in GitHub interface by accepting [my 
suggestion](https://github.com/openjdk/jdk/pull/25698#discussion_r2154723332).

(I've removed yesterday's comments for `Modality.html`.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25698#issuecomment-2984405779

Reply via email to