On Fri, 20 Jun 2025 12:35:12 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>This specific bug was for Windows only, the fix was presumably in Windows-only 
>code, this is why I don't care much about other L&F.

It does not matter where the bug was if it can be reproduced via the public 
API. It is quite common for a test written for one platform later catch a bug 
on another.

>Even if the text was displayed outside of the button, it was Windows-specific.
How do we know that if we did not run the test on non-windows platforms?

>Additionally, it's a manual test. If the test is automated, it makes more 
>sense to test for all L&Fs; for a manual test, I'd rather avoid testing in 
>other L&F because the bug never existed there.

For a manual test it is unnecessary but I think it should be possible to 
automate. And checking of all L&F depends only on how the bug can be triggered 
and what is wrong.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25883#discussion_r2159839180

Reply via email to