On Thu, 26 Jun 2025 04:55:01 GMT, Abhishek Kumar <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 62:
>
>> 60: frame.pack();
>> 61: frame.setLocationRelativeTo(null);
>> 62: frame.setVisible(true);
>
> You may move UI implementation code to helper method.
Not needed strictly..good to have linear flow..
> test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 67:
>
>> 65: robot.waitForIdle();
>> 66: robot.delay(1000);
>> 67: int selectedRowCount = tree.getSelectionCount();
>
> `tree.getSelectionCount()` on EDT ?
ok
> test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 82:
>
>> 80: System.out.println("rows selected " + curSelectedRowCount);
>> 81: if (curSelectedRowCount != selectedRowCount + 2) {
>> 82: throw new RuntimeException("ctrl+shift+down not
>> working");
>
> Does it sound better ?
> Suggestion:
>
> throw new RuntimeException("ctrl+shift+down does not select
> next row");
ok
> test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 89:
>
>> 87: robot.keyRelease(KeyEvent.VK_UP);
>> 88: robot.keyRelease(KeyEvent.VK_SHIFT);
>> 89: robot.keyRelease(KeyEvent.VK_CONTROL);
>
> Helper method can be used to perform robot operations.
not needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25966#discussion_r2168122496
PR Review Comment: https://git.openjdk.org/jdk/pull/25966#discussion_r2168122791
PR Review Comment: https://git.openjdk.org/jdk/pull/25966#discussion_r2168122589
PR Review Comment: https://git.openjdk.org/jdk/pull/25966#discussion_r2168122892
