On Fri, 20 Jun 2025 03:09:32 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is > not displayed in WindowsL&F when the test is run with NimbusL&F. > This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called > `getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be > drawn. This is because the test after setting WIndows L&F of the menuitem > reverts back the Windows L&F to Nimbus L&F via > `UIManager.setLookAndFeel(save);` call in the test so when frame is made > visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon. > > Fix is made to make sure the whole frame is updated to cater to L&F change > via `SwingUtilities.updateComponentTreeUI(frame);` call and keep the L&F > without reverting back to original L&F.. > The test has to re-create its UI after testing for a L&F is complete. Such a > scenario isn't supported by `PassFailJFrame` at the moment, see > [JDK-8357455](https://bugs.openjdk.org/browse/JDK-8357455) and [#24439 > (comment)](https://github.com/openjdk/jdk/pull/24439#discussion_r2100038079). > There's no easy workaround. > > The test doesn't receive events from `PassFailJFrame`, so the needs to be a > custom UI, or the test should be run several times for different L&Fs. So do you propose to test like what is being done in https://github.com/openjdk/jdk/pull/24439/files passing L&F argument to jtreg tag? ------------- PR Comment: https://git.openjdk.org/jdk/pull/25907#issuecomment-3035935556
