On Fri, 11 Jul 2025 18:05:57 GMT, Phil Race <p...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust offset for varying size imageicon > > test/jdk/javax/swing/JMenuItem/TestRadioAndCheckMenuItemWithIcon.java line 31: > >> 29: * JRadioButtonMenuItem and JCheckboxMenuItem >> 30: * is rendered with ImageIcon in WindowsLookAndFeel >> 31: * @requires (os.family == "windows") > > Can't we run this with all L&Fs on all platforms ? > What about it would be so different in some other case ? > > Also that last update for different sized icons isn't being tested - so can > we vary the icon size in this test ? Should we run this test for all L&Fs? So far, Windows L&F was unique in the way that it combined both check marks / bullets and icons. If we implement it the new way so that all the check marks / bullets and menu icons align, the menu behaviour in Windows L&F will be the same as that in Metal and Nimbus at least. `javax/swing/JMenuItem/RightLeftOrientation.java` tests a similar scenario. If the behaviour of Windows L&F is the same as in other L&F, we may just add this bug id to an existing test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2201835865
