On Fri, 11 Jul 2025 09:25:43 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Jeremy Wood has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - 8358813: putting the actions in a TreeSet >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/25688#discussion_r2200230806 >> - 8358813: make input map types a static constant >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/25688#discussion_r2200225191 >> - Merge branch 'master' into JDK-8358813 >> - Update >> test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java >> >> Co-authored-by: Andrey Turbanov <turban...@gmail.com> >> - 8358813: remove more bindings for JPasswordFields in Aqua > > src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 1: > >> 1: /* > > Please, update the copyright year. This is no longer necessary after merging with master ( see 2bff8e0a1382f8820bc2479af87e45dc6b74cdb5 ) > test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java line > 76: > >> 74: JComponent.WHEN_FOCUSED, >> 75: JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT >> 76: }) { > > The array with input map types could be a static constant just above > `runTest` method. OK, this is updated. > test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java line > 93: > >> 91: actionBinding == DefaultEditorKit.nextWordAction >> || >> 92: actionBinding == >> DefaultEditorKit.selectionPreviousWordAction || >> 93: actionBinding == >> DefaultEditorKit.selectionNextWordAction ) { > > Does it make sense to put the actions in a list or array? Then > `listOfActions.contains(actionBinding)` instead of this long `if` condition? I don't have a preference. I pushed an update that wraps them in a TreeSet. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25688#discussion_r2202281546 PR Review Comment: https://git.openjdk.org/jdk/pull/25688#discussion_r2202281420 PR Review Comment: https://git.openjdk.org/jdk/pull/25688#discussion_r2202281674
