On Wed, 16 Jul 2025 20:57:40 GMT, Phil Race <[email protected]> wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8362291
src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 157:
> 155: deregisterDisplayReconfiguration(displayReconfigContext);
> 156: } catch (Throwable t) {
> 157: // Runs on disposer thread, can't allow an exception to
> escape.
What do you think about moving this "catch Throwable" into Disposer itself? As
of now since https://github.com/openjdk/jdk/pull/9890 we ignore "Exception"
only.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2211699632
