On Tue, 22 Jul 2025 15:13:44 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the >> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24. >> >> The following files still reference `jdk.jsobject` (or the >> `netscape.javascript` package). They are not modified because these files >> reflect the state of earlier releases, which do have the `jdk.jsobject` >> module. >> >> >> src/jdk.compiler/share/data/symbols/jdk.jsobject-9.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-A.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-B.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-C.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-E.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-G.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-M.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.jsobject-O.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-8.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-9.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-B.sym.txt >> src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-F.sym.txt >> src/jdk.compiler/share/data/symbols/symbols >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/releases/element-list-10.txt >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/releases/element-list-9.txt >> test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list >> >> >> I have run tier1, tier2, and tier3 tests, as well as local tests with JavaFX >> WebView. > > test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list line 305: > >> 303: jdk.jshell.spi >> 304: jdk.jshell.tool >> 305: module:jdk.jsobject > > There is a similar pair in > test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list. > Can it be removed? Unless it causes a test failure. I wondered about that, and originally was going to remove it, but then noticed that the test in question parses the JDK 17 API docs (which does have the `jdk.jsobject` module). https://github.com/openjdk/jdk/blob/e70c702d6f864b494dc7df3eea4f1a317a3bc981/test/langtools/jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java#L55-56 private static final String externalDocs = "https://docs.oracle.com/en/java/javase/17/docs/api";; I suspect that the test will run just fine if I remove it. I don't mind either way. What would you recommend? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26393#discussion_r2223507650
