On Wed, 16 Jul 2025 23:15:37 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> Some useful methods in ExtendedRobot should be migrated into Robot itself so 
>> that ExtendedRobot can be removed in the future. The tests using 
>> ExtendedRobot for these migrated methods are changed to use only Robot 
>> (removing unnecessary building of ExtendedRobot).
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   update robot specification

Changes requested by prr (Reviewer).

src/java.desktop/share/classes/java/awt/Robot.java line 140:

> 138: 
> 139:     private static int stepDelay = DEFAULT_STEP_DELAY;
> 140:     private static int stepLength = DEFAULT_STEP_LENGTH;

These should not be static. They apply to THIS robot instance, not all of them.

src/java.desktop/share/classes/java/awt/Robot.java line 948:

> 946:             throw new IllegalArgumentException("Step-length must be 
> greater than zero");
> 947:         }
> 948:         Robot.stepLength = stepLength;

Not a static

src/java.desktop/share/classes/java/awt/Robot.java line 977:

> 975:             throw new IllegalArgumentException("Step delay must be 
> between 0 and 60,000");
> 976:         }
> 977:         Robot.stepDelay = stepDelay;

Not a static

-------------

PR Review: https://git.openjdk.org/jdk/pull/22044#pullrequestreview-3045031189
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2223932815
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2223934691
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2223934886

Reply via email to