On Wed, 23 Jul 2025 08:43:33 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of >> ImageIcon, a null pointer exception is thrown at runtime. >> The code tried to get the `id` for that image and instantiates >> `MediaTracker` to associate the null image to that `id` and checks the >> status of loading this null image, removes the null image from the tracker >> and then tries to get the image width where it throws NPE as image is null. >> >> It's better to not go through all MediaTracker usage and bail out initially >> itself for null image.. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unneeded vars src/java.desktop/share/classes/javax/swing/ImageIcon.java line 64: > 62: * are preloaded using MediaTracker to monitor the loaded state > 63: * of the image. > 64: * If the image source parameter to a constructor is non-null, Whilst reviewing the CSR I realized you need to change the line above to say "If the image source parameter to a constructor or method is non-null," I made that change in the CSR. Do it here too. It is needed to cover setImage() ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2229416113
