On Fri, 25 Jul 2025 07:31:42 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Issue is seen that a popup doesn't get closed when the component that >> invokes it, gets removed from the parent container. >> This is because the JPopupMenu does not listen to its invoker liefecycle >> thereby behaving as a standalone entity after creation. >> Fix is made to make sure popup listens to its invoker lifecycle by >> registering its PropertyChangeListener to the invoker and listens to the >> ["ancestor" property name ], >> https://github.com/openjdk/jdk/blob/441dbde2c3c915ffd916e39a5b4a91df5620d7f3/src/java.desktop/share/classes/javax/swing/JComponent.java#L4853-L4858 >> which will become null when removed, wherein we should dispose of the popup > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Use setVisible(false) instead of dispose, update test src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 1383: > 1381: values.addElement("propListener"); > 1382: values.addElement(propListener); > 1383: } Do we need to serialise `propListener`? What is the value in serialising the listener? Will `invoker` serialise `propListener`? If it does, then we need to serialise it to be able to remove the listener after the components are deserialised and the `invoker` is changed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2237320973
