On Tue, 12 Aug 2025 14:54:58 GMT, Alexey Ivanov <[email protected]> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates copyright years
>
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 118:
>
>> 116: jbutton.setForeground(jbColor);
>> 117: jbutton.setBackground(jbColor);
>> 118: jbutton.setOpaque(true);
>
> This should be the default value, I mean Swing components are usually opaque
> unless it's changed by app developer or look and feel. For example, rounded
> corners may make the component non-opaque as the background in the rounded
> corners has to be painted by the parent component.
I have removed the additional setOpaque code. I am doing the necessary tests.
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 177:
>
>> 175: btnLoc = jbutton2.getLocationOnScreen();
>> 176: c = robot.getPixelColor(btnLoc.x + 5, btnLoc.y + 5);
>> 177: System.out.println("Color picked for jbutton2: "+c);
>
> Suggestion:
>
> System.out.println("Color picked for jbutton2: " + c);
>
> Spaces around binary operators.
> This applies to other similar cases.
I have gone through the test and added spaces around binary operators.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2270517195
PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2270509634
