On Tue, 12 Aug 2025 15:03:04 GMT, Alexey Ivanov <[email protected]> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates CountDownLatch waiting time to one second
>
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 169:
>
>> 167: throw new RuntimeException("Ancestor frame didn't
>> receive " +
>> 168: "focus");
>> 169: }
>
> The same comments as for `GlassPaneOverlappingTestBase.java`.
>
> The latch may never release because you don't call its `countDown` method if
> `ancestor` is `null`. Can `ancestor` be `null`?
It looks for me that ancestor could never be null. All components (Including
embedded frame test) reside in a frame. But, to be on the safe side, I will
include the case where ancestor could be null, in case this occurs.
Same for GlassPaneOverlappingTestBase.java, if component support resizing. I
will add code to release the latch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2279515856
