On Wed, 20 Aug 2025 08:58:03 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Anass Baya has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   add waitForIdle()
>
> test/jdk/javax/swing/DataTransfer/bug4655513.java line 73:
> 
>> 71:                 robot.delay(20);
>> 72:             }
>> 73:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 
> mousePress parameter should be `InputEvent.BUTTON1_DOWN_MASK` instead which 
> is usually the norm? mouseRelease is called correctly..
> Also, I dont think we usually use delay between drag...guess once drag is 
> complete, we can call waitForIdle and delay..

Hello @prsadhuk,
We need to add at least waitForIdle() before releasing the mouse button. 
Otherwise, the test will start failing again.
KR,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26824#discussion_r2299767057

Reply via email to