On Thu, 28 Aug 2025 06:27:41 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Make vars static
>
> src/java.desktop/share/classes/java/awt/Robot.java line 813:
> 
>> 811:         mousePress(buttons);
>> 812:         waitForIdle(20);
>> 813:         mouseRelease(buttons);
> 
> It would be good to call ***release methods in the finally block.

Is this necessary? Would I have to account for accidentally releasing any 
buttons that should still be pressed by calling `mouseRelease(buttons)` in a 
`finally` block if some exception is thrown during `mousePress`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26969#discussion_r2308455470

Reply via email to