On Fri, 29 Aug 2025 02:30:36 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> * Add `@requires os.family == "linux"` to prevent GTK L&F tests from running
>> on other OS but Linux.
>> * Let any exceptions from `UIManager.setLookAndFeel` propagate.
>> * Remove `@author` tag.
>> * Expand imports in `test/jdk/com/sun/java/swing/plaf/gtk/Test6635110.java`.
>> * Add leading asterisks to jtreg comment block.
>
> test/jdk/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java line 37:
>
>> 35: public class bug4928019 {
>> 36: public static void main(String[] args) throws Throwable {
>> 37:
>> UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
>
> WHy to restrict it to only GTK? We can iterate it for all installed L&Fs, no?
> We have similar fixes in particular L&F but then extend the test for all L&F
> just to ensure it works ok for all L&F..
This is the question to the original author of the test. I do not change the
logic of the test. If the test is designed to run with GTK L&F only, let it be.
If you feel a test has to be extended to cover all L&Fs, submit a bug to expand
the test to other L&Fs.
The purpose of this PR is to avoid running GTK L&F specific tests on the
platforms where GTK L&F isn't available.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26995#discussion_r2309536374
