On Thu, 4 Sep 2025 14:38:59 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 36:
>
>> 34:
>> 35: /**
>> 36: * Base class for testing overlapping of Swing and AWT component put
>> into GlassPane.
>
> My IDE highlights that `ancestorLoc` is never used now.
Variable removed.
> test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 694:
>
>> 692: }
>> 693: }// class LWComboBox
>> 694:
>
> One blank line is enough.
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 73:
>
>> 71: }
>> 72:
>> 73: protected boolean isMultiFramesTest(){
>
> Suggestion:
>
> protected boolean isMultiFramesTest() {
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 185:
>
>> 183:
>> 184: clickAndBlink(robot, lLoc);
>> 185: if (ancestor != null && MULTI_FRAMES_TEST) {
>
> Suggestion:
>
> if (ancestor != null && isMultiFramesTest()) {
>
> If you introduce the method to return the flag and the flag is used in one
> place only, call the method instead of storing its value in field.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322702924
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322696697
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322699561
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322695966
