On Thu, 4 Sep 2025 16:30:40 GMT, lawrence.andrews <[email protected]> wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Feedback: Removed redundant RTEs
>
> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 151:
>
>> 149: robot.setAutoDelay(150);
>> 150: robot.setAutoWaitForIdle(true);
>> 151: if (!windowFocusGainedLatch.await(1500, TimeUnit.MILLISECONDS))
>> {
>
> Once there is a timeout, we know the frame did not gain focus. Can we throw
> exception and stop execution ?
Yes, that was the code initially. The previous review suggested removal of the
code as being redundant in the presence of the main method's throws Exception.
There are pros and con to argue on both ways. Please let me know if you strong
reason to not ok to not have in the current form.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26471#discussion_r2324570191
