On Thu, 11 Sep 2025 14:51:27 GMT, Alexander Zvegintsev <[email protected]> wrote:
>> There are several major issues with the test: >> >> 1. The `frameExited` variable is set to true when the mouse pointer exits >> the frame. The test does not expect this to happen with the first mouse >> click on the `choice` when the mouse pointer is already over the test frame >> (frame mouseExited - > choice mouseEntered). A reset for the frameExited was >> added. >> 2. The test does not wait for the frame to appear after the call to >> `setVisible()`, so the test can start operating not on a fully visible >> window (e.g. one with an appearance animation). A delay has been added. >> 3. In macOS, the direction of rotation of the mouse wheel is different, >> which was not taken into account. >> >> Testing looks good. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > review comments Changes LGTM. test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java line 28: > 26: * @key headful > 27: * @bug 7050935 > 28: * @summary > closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on > win32 Minor: You may want to change the test path in the summary ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27161#pullrequestreview-3218393787 PR Review Comment: https://git.openjdk.org/jdk/pull/27161#discussion_r2345163870
