On Mon, 15 Sep 2025 05:17:12 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>>
>> I have updated the insets calculation, similar calculation observed in
>> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified
>> code
>>
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Moved test position based on suggesion
src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line 152:
> 150: applyInsets(rect, insets, ture);
> 151: }
> 152: }
Just call directly, the null-check is inside in the called method.
You've got a typo: `ture` → `true`.
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
line 557:
> 555:
> 556: static void applyInsets(Rectangle rect, Insets insets, boolean
> leftToRight) {
> 557: if (insets != null) {
No need for null-check here, it's present in the called method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2349352307
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2349353764
