On Mon, 15 Sep 2025 17:13:32 GMT, Phil Race <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Check for failure in 1st frame activation
>
> test/jdk/java/awt/Focus/ActivateFocusTest.java line 57:
>
>> 55: boolean testFailed = false;
>> 56: for (int i = 0; i < NUM_FRAMES; i++) {
>> 57: testFailed = (af[i].lw.focusCounter > 1);
>
> I don't understand this code. If the first one fails, and the second one
> passes it will pass the test when I presume it should have failed it.
I have updated the PR to check for 1st frame `testFailed ` too
Also, regarding renaming the test to FocusActiveFocusTest.java, I guess there's
too many Focus in the name and I dont see any wrong in the present name
ActivateFocus which seems to be right considering what it is testing, which is
`focus on window activation` so unless it's a deal-breaker, I guess we can keep
the name
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27214#discussion_r2350536351
