On Fri, 19 Sep 2025 01:14:33 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Test used to timeout even though it seems the test passed..Increased the >> timeout to a safe value as sometimes it shows elapsed time to timeout > >> 300secs in macOS in CI and also ensured the wait-time for child process to >> execute the test is not been waiting endlessly. >> Also ensured the original display mode is resetted after the test to prevent >> affecting following tests. >> >> Tried 100 iterations of the fix on all platforms which is ok > > test/jdk/java/awt/FullScreen/UninitializedDisplayModeChangeTest/DisplayModeChanger.java > line 69: > >> 67: f.dispose(); >> 68: } >> 69: gd.setDisplayMode(currentDM); > > Should not this be already reset by the gd.setFullScreenWindow(null)? I dont see it does..It sets the bounds as I see, it does not reset the display mode.. but say, even though it does, will it be a problem as this will be a no-op (its like double free) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27365#discussion_r2361614626
