On Thu, 18 Sep 2025 06:59:55 GMT, Tejesh R <[email protected]> wrote: >> Test is failing frequently on mach5 machines. I have fixed it with >> stabilizations and moved the frame to center of the screen. After the fix >> several runs were made on mach5 and no failures were seen. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix
It would be logical to add `waitForIdle` *after all the dragging is finished*, after line 187. That is right before `robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK)` and `robot.keyRelease(KeyEvent.VK_CONTROL)` are called. This is what I asked for. And you've reverted no formatting changes, please revert formatting changes on the lines you don't touch. test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 134: > 132: > 133: Toolkit.getDefaultToolkit() > 134: .addAWTEventListener(this, AWTEvent.MOUSE_EVENT_MASK); This is not resolved, the changeset still adds a space for no reason. Nothing else but formatting is changed around `Toolkit.getDefaultToolkit().addAWTEventListener`. ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27283#pullrequestreview-3246805575 PR Review Comment: https://git.openjdk.org/jdk/pull/27283#discussion_r2364316249
