On Wed, 17 Sep 2025 23:39:04 GMT, Daniel Gredler <[email protected]> wrote:
>>> @prrace: In the [CSR](https://bugs.openjdk.org/browse/JDK-8366563) for this >>> change, Joe said "Please consider whether or not a release note is >>> warranted for the behavior change on which exception gets thrown." I think >>> this is above my pay grade, no? Do I need to raise any flags with anyone >>> about this? >> >> >> I don't think it is high profile enough to need a release note. >> >> However one thing that you forgot is that I wrote early on in this PR : >> "Several JCK tests for TextLayout constructor fail (surprise !) >> They all fail because they use a null FRC. >> We need a CSR for this anyway but I'll need to co-ordinate problem listing >> those tests as part of this bug so we don't see failures as soon as it is >> pushed." >> >> meaning I was hoping I could push that problem listing (it is an internal >> thing) right at the same time you pushed, because our CI system started to >> report the failures already. > >> I don't think it is high profile enough to need a release note. > > OK, sounds good. > >> I was hoping I could push that problem listing (it is an internal thing) >> right at the same time you pushed > > Ah, I'm sorry -- I didn't realize you meant that level of coordination! Hi @gredler, can you please take a look to [this](https://github.com/openjdk/jdk/blob/cc65836d00de7041e7d32e7f15d98108b1ae47a0/src/java.desktop/share/classes/sun/java2d/pipe/OutlineTextRenderer.java#L76) code in OutlineTextRenderer: if ("".equals(str)) { return; // TextLayout constructor throws IAE on "". } TextLayout tl = new TextLayout(str, g2d.getFont(), g2d.getFontRenderContext()); Do we still need it after this patch? ------------- PR Comment: https://git.openjdk.org/jdk/pull/26947#issuecomment-3315270892
