On Thu, 25 Sep 2025 11:23:18 GMT, Ravi-Patel8 <[email protected]> wrote:

>> Bug Ref: https://bugs.openjdk.org/browse/JDK-8368606
>> 
>> As part of [JDK-8344057](https://bugs.openjdk.org/browse/JDK-8344057) 
>> ("Remove doPrivileged calls from unix platform sources in the java.desktop 
>> module"), changes were made to execCmd() in
>>  `src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java`.
>> In the updated implementation, execCmd(...) code is missing to initialize 
>> the results variable. It declares it as null and then tries to 
>> results.add(line), which prevents the results list from being populated with 
>> printer names.
>> 
>> Initializing the results variable will resolve the issue.
>> 
>> 
>> Signed-off-by: Ravi.Patel8 <[email protected]>
>
> Ravi-Patel8 has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Updated Comments
>    
>    Signed-off-by: Ravi.Patel8 <[email protected]>
>  - Add catch block to log exception details for troubleshooting printer
>    command
>    
>    Signed-off-by: Ravi.Patel8 <[email protected]>

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/27482#pullrequestreview-3269908410

Reply via email to