On Wed, 8 Oct 2025 05:47:33 GMT, Jeremy Wood <[email protected]> wrote:
>> Previously: >> >> If DesktopProperty#updateAllUIs threw an exception, we would never reset the >> update-pending property to false. This means any subsequent call to >> `updateUI()` would not attempt to call `updateAllUIs()` >> >> With this change: >> Subsequent calls to DesktopProperty#updateUI() can still trigger at least >> one call to updateAllUIs(). > > Jeremy Wood has updated the pull request incrementally with two additional > commits since the last revision: > > - 8367376: adding @key headful > > This is in response to the second point here: > https://github.com/openjdk/jdk/pull/27205#discussion_r2412548662 > - 8367376: adding Frame.dispose() in try/finally > > This is in response to the first point here: > https://github.com/openjdk/jdk/pull/27205#discussion_r2412548662 Marked as reviewed by aivanov (Reviewer). test/jdk/com/sun/java/swing/plaf/DesktopPropertyResetPendingFlagTest.java line 31: > 29: * @run main DesktopPropertyResetPendingFlagTest > 30: * @key headful > 31: */ Suggestion: /* * @test * @bug 8367376 * @key headful * @summary DesktopProperty never reset pending status to process new updates * @modules java.desktop/sun.swing.plaf * @run main DesktopPropertyResetPendingFlagTest */ It doesn't really matter, yet usually `@key` comes after the `@bug` tag. ------------- PR Review: https://git.openjdk.org/jdk/pull/27205#pullrequestreview-3314186501 PR Review Comment: https://git.openjdk.org/jdk/pull/27205#discussion_r2413408274
